Skip to content

Combine impl<'a> Arguments<'a> blocks #148940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2025
Merged

Combine impl<'a> Arguments<'a> blocks #148940

merged 1 commit into from
Nov 14, 2025
+15 −17

Conversation

@dtolnay
Copy link
Member

@dtolnay dtolnay commented Nov 14, 2025

This makes a difference in the documentation rendered by rustdoc.

Before:

After:

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 14, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 14, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@joboet
Copy link
Member

joboet commented Nov 14, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 14, 2025

📌 Commit 85332e3 has been approved by joboet

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 14, 2025
@joboet joboet assigned joboet and unassigned Mark-Simulacrum Nov 14, 2025
@bors
Copy link
Collaborator

bors commented Nov 14, 2025

⌛ Testing commit 85332e3 with merge c910098...

@bors
Copy link
Collaborator

bors commented Nov 14, 2025

☀️ Test successful - checks-actions
Approved by: joboet
Pushing c910098 to main...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 14, 2025
@bors bors merged commit c910098 into rust-lang:main Nov 14, 2025
12 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 14, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing c8551d3 (parent) -> c910098 (this PR)

Test differences

Show 176 test diffs

176 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard c91009892b4cd1776d4c9d85793166612195a03d --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. aarch64-apple: 7171.6s -> 10662.9s (+48.7%)
  2. dist-apple-various: 3486.2s -> 4840.1s (+38.8%)
  3. dist-x86_64-apple: 8581.8s -> 6396.7s (-25.5%)
  4. pr-check-1: 1846.5s -> 1462.0s (-20.8%)
  5. aarch64-msvc-2: 4604.5s -> 5428.2s (+17.9%)
  6. dist-aarch64-apple: 6618.1s -> 7794.6s (+17.8%)
  7. i686-gnu-2: 6279.7s -> 5167.6s (-17.7%)
  8. aarch64-gnu-debug: 4608.1s -> 3822.9s (-17.0%)
  9. x86_64-gnu-llvm-21-1: 3693.0s -> 3201.3s (-13.3%)
  10. i686-gnu-1: 8393.2s -> 7351.1s (-12.4%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

rust-timer commented Nov 14, 2025

Finished benchmarking commit (c910098): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 1.3% [1.2%, 1.4%] 5
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (secondary 3.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.9% [2.4%, 4.7%] 3
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Cycles

Results (primary 3.0%, secondary -3.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 3.0% [3.0%, 3.0%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -3.2% [-3.2%, -3.2%] 1
All ❌✅ (primary) 3.0% [3.0%, 3.0%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 473.369s -> 472.486s (-0.19%)
Artifact size: 388.69 MiB -> 388.72 MiB (0.01%)

@dtolnay dtolnay deleted the implarguments branch November 14, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@joboet joboet

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

6 participants

@dtolnay @rustbot @joboet @bors @rust-timer @Mark-Simulacrum